[PATCH] D20085: [libfuzzer] Refactoring coverage state-management code..
Mike Aizatsky via llvm-commits
llvm-commits at lists.llvm.org
Tue May 10 15:38:33 PDT 2016
aizatsky added a comment.
All Done. PTAL.
================
Comment at: lib/Fuzzer/FuzzerInternal.h:321
@@ +320,3 @@
+
+ std::string DebugString() const;
+
----------------
kcc wrote:
> is this used?
Not right now, but I used it several times for debugging. I'd like to keep it.
================
Comment at: lib/Fuzzer/FuzzerLoop.cpp:401
@@ -314,3 +400,3 @@
- PrepareCoverageBeforeRun();
+ CoverageController::ResetCounters(Options);
ExecuteCallback(Data, Size);
----------------
kcc wrote:
> aizatsky wrote:
> > BTW all tests pass without this call, but you used to have it before. Do you want me to keep it?
> let's not make too many changes at the same time, leave it for now.
Added comment.
http://reviews.llvm.org/D20085
More information about the llvm-commits
mailing list