[PATCH] D20085: [libfuzzer] Refactoring coverage state-management code..

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 14:56:13 PDT 2016


aizatsky added a comment.

Made sure that no additional allocations happen. PTAL.


================
Comment at: lib/Fuzzer/FuzzerTracePC.h:1
@@ +1,2 @@
+//===- FuzzerTracePC.h - INTERNAL - Path tracer i-face. --------*- C++ -* ===//
+//
----------------
kcc wrote:
> i-face? really? 
> 
> I don't want to expose this in a header file. 
> I see why you did this (to have mergeable objects), but that might be a bad idea because of extra memory allocations. 
Trying to stay within 80 chars.

I don't really need this header. I had this in FuzzerInternal.h first. I'm happy to move this definition back. I simply presumed that you'd like to keep it separate.


http://reviews.llvm.org/D20085





More information about the llvm-commits mailing list