[PATCH] D20019: [PPC] initial exploitation of xs[min,max]cdp

Ehsan Amiri via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 13:50:08 PDT 2016


amehsan added inline comments.

================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:461
@@ -460,1 +460,3 @@
 
+static bool isDoubleLegalMinOrMax(SDNode *N) {
+
----------------
nemanjai wrote:
> Why the restriction to double precision values? The ISA document mentions this instruction can be used for both single and double precision operands.
Thanks. I missed the foot note, and I had totally forgot the fact that single precisions are represented in double precision format when stored in a register (talking about scalar operations), so I didn't make the conclusion myself.


http://reviews.llvm.org/D20019





More information about the llvm-commits mailing list