[PATCH] D13741: Introduce a *draft* of a code of conduct for the LLVM community and theassociated reporting guide.

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 12:53:32 PDT 2016


joker.eph accepted this revision.
joker.eph added a reviewer: joker.eph.
joker.eph added a comment.
This revision is now accepted and ready to land.

Since you ask for an "ack" on the mailing-list: LGTM, with some minor comments inline. 
You probably want to wait for a lot more approval here before committing though... :)


================
Comment at: docs/CodeOfConduct.rst:96
@@ +95,3 @@
+  a viewpoint doesn’t mean that they’re wrong. Don’t forget that it is human to
+  err and blaming each other doesn’t get us anywhere. Instead, focus on helping
+  to resolve issues and learning from mistakes.
----------------
Is the short "err" intentional here?

================
Comment at: docs/ReportingGuide.rst:117
@@ +116,3 @@
+a public mailing list. Doing so would involve disclosure of information which
+whould be confidential. Disclosing this kind of information publicly may be
+considered a separate and (potentially) more serious violation of the Code of
----------------
`whould`, if it is a proper word, it is not very common I think, you may want an alternative to be friendlier with non-native English speaker :)

================
Comment at: docs/ReportingGuide.rst:122
@@ +121,3 @@
+**please** refrain from mentioning specific facts about cases without the
+explicit permission of all parties involved.
+
----------------
I'm a bit torn on this paragraph, looks like a "gag order" (you may be sanctioned in some way by a committee and forbid to discuss why with the community).


http://reviews.llvm.org/D13741





More information about the llvm-commits mailing list