[lld] r268495 - Print the cpio trailer after every member.

[Rafael Espíndola via llvm-commits]

On 10 May 2016 at 15:08, Sean Silva <chisophugis at gmail.com> wrote:
>
>
> On Tue, May 10, 2016 at 8:48 AM, Rui Ueyama <ruiu at google.com> wrote:
>>
>> Looks like it should be 3 exclamation points.
>>
>>
>> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html#tag_20_92_13_11
>
>
> Thanks for digging that up. I don't think we can get much more official than
> POSIX. Can you add the link?
>

Like this?

Cheers,
Rafael
-------------- next part --------------
diff --git a/ELF/DriverUtils.cpp b/ELF/DriverUtils.cpp
index 23e3ac1..06b0b65 100644
--- a/ELF/DriverUtils.cpp
+++ b/ELF/DriverUtils.cpp
@@ -150,6 +150,8 @@ static void maybePrintCpioMember(StringRef Path, StringRef Data) {
 
   // Print the trailer and seek back. This way we have a valid archive if we
   // crash.
+  // See http://pubs.opengroup.org/onlinepubs/9699919799/utilities/pax.html#tag_20_92_13_11
+  // for the format details.
   uint64_t Pos = OS.tell();
   maybePrintCpioMemberAux(OS, "TRAILER!!!", "");
   OS.seek(Pos);