[PATCH] D19901: [ProfileData] (llvm) Use Error in InstrProf and Coverage

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 11:07:03 PDT 2016


vsk updated this revision to Diff 56760.
vsk added a comment.

- Move EnumBasedError to ProfileCommon.h so SampleProf can reuse it later.
- Remove EnumBasedError::create(), remove the DerivedError CRTP, and use Error::success()/make_error<> everywhere explicitly.
- Honor the convertToErrorCode contract.


http://reviews.llvm.org/D19901

Files:
  include/llvm/ProfileData/Coverage/CoverageMapping.h
  include/llvm/ProfileData/Coverage/CoverageMappingReader.h
  include/llvm/ProfileData/InstrProf.h
  include/llvm/ProfileData/InstrProfData.inc
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  include/llvm/ProfileData/ProfileCommon.h
  lib/ProfileData/Coverage/CoverageMapping.cpp
  lib/ProfileData/Coverage/CoverageMappingReader.cpp
  lib/ProfileData/InstrProf.cpp
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  lib/Transforms/Instrumentation/InstrProfiling.cpp
  lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  tools/llvm-cov/CodeCoverage.cpp
  tools/llvm-profdata/llvm-profdata.cpp
  unittests/ProfileData/CoverageMappingTest.cpp
  unittests/ProfileData/InstrProfTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19901.56760.patch
Type: text/x-patch
Size: 104941 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160510/c68a6d53/attachment.bin>


More information about the llvm-commits mailing list