[PATCH] D20089: Adding a TargetParser for AArch64

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Tue May 10 02:55:06 PDT 2016


rengolin added a comment.

In http://reviews.llvm.org/D20089#425525, @bsmith wrote:

> There is an awful lot of duplication/passing through to another class in this, it strikes me that this whole thing could benefit from some level of inheritance. I think it would be good to have a base class that defines the interface and have both ARM/AArch64 (and any other architectures that want to use this in the future) implement this interface. That way all of this code can be called generically from clang/wherever.


Well...

http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150824/296862.html

One option is to add the duplication, solve all the platform problems first, then move to a class based design.

Another is to go directly to a class based design, but that would mean a much bigger move.

I'm ok with either, but I'd prefer a slow and steady change stream.


Repository:
  rL LLVM

http://reviews.llvm.org/D20089





More information about the llvm-commits mailing list