[PATCH] D20063: [Clang][AVX512] completing missing intrinsics [load/store].

[Asaf Badouh via llvm-commits]

AsafBadouh added inline comments.

================
Comment at: test/CodeGen/avx512f-builtins.c:94
@@ +93,3 @@
+{
+  // CHECK-LABEL: @test_mm512_store_si512 
+  // CHECK: load <8 x i64>, <8 x i64>* %__A.addr.i, align 64
----------------
please remove the "return" from all void tests


================
Comment at: test/CodeGen/avx512f-builtins.c:97
@@ +96,3 @@
+  // CHECK: load i8*, i8** %__P.addr.i, align 8
+  // CHECK: bitcast i8* %3 to <8 x i64>*
+  return _mm512_store_si512 ( __P,__A);
----------------
please add CHECK for the store

================
Comment at: test/CodeGen/avx512f-builtins.c:106
@@ +105,3 @@
+  // CHECK: load i8*, i8** %__P.addr.i, align 8
+  // CHECK: bitcast i8* %3 to <8 x i64>*
+  return _mm512_store_epi32 ( __P,__A);
----------------
please add CHECK for the store


================
Comment at: test/CodeGen/avx512f-builtins.c:115
@@ +114,3 @@
+  // CHECK: load i8*, i8** %__P.addr.i, align 8
+  // CHECK: bitcast i8* %3 to <8 x i64>*
+  return _mm512_store_epi64 ( __P,__A);
----------------
please add CHECK for the store


================
Comment at: test/CodeGen/avx512f-builtins.c:237
@@ +236,3 @@
+
+__m512 test_mm512_maskz_load_ps(__mmask16 __U, void *__P)
+{
----------------
you have it already in line:189

================
Comment at: test/CodeGen/avx512f-builtins.c:266
@@ +265,3 @@
+__m512d test_mm512_maskz_load_pd(__mmask8 __U, void *__P)
+{
+  // CHECK-LABEL: @test_mm512_maskz_load_pd
----------------
you have it already in line:244


http://reviews.llvm.org/D20063