[PATCH] D19503: [MemorySSA] Overhaul CachingMemorySSAWalker's cache to allow more selective cache invalidation

George Burgess IV via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 17:29:17 PDT 2016


george.burgess.iv abandoned this revision.
george.burgess.iv added a comment.

> Also, the presence of both code motion and semantic changes makes this essentially impossible to review quickly. Please make the code motion changes separately, land them, and then update the patch. If we disagree about where the code lives, we can move it again later. Your suggestion seems reasonable enough and I doubt we'll care too much


Will do (in the future).

> If we can't make this work in the new caching scheme, we should fix the new caching scheme


That sounds like it's going to be a lot of invalidation, which this cache probably won't like very much. I'll see if I can do something that's more invalidation-friendly, then. :)

Thanks for the feedback!


http://reviews.llvm.org/D19503





More information about the llvm-commits mailing list