[PATCH] D20072: Prevent DW_AT_abstract_origin from being emitted twice for the same subprogram

[Adrian Prantl via llvm-commits]

aprantl added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:525
@@ -524,2 +524,3 @@
 void DwarfDebug::finishSubprogramDefinitions() {
+  SmallPtrSet<const MDNode *, 16> FinalizedSPNodes;
   for (auto &F : MMI->getModule()->functions())
----------------
dblaikie wrote:
> Do we need the extra data structure? How did this code work before the CU<>Subprogram inversion?
Ok, this is a really good question. There is no evidence for this code existing prior to the CU<>Subprogram inversion and the test suite still passes after removing it.


http://reviews.llvm.org/D20072