[PATCH] D20078: PGO] Fix __llvm_profile_raw_version linkage in MACHO

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 13:28:06 PDT 2016


vsk added a comment.

Wow, so without this fix are IR profiles unusable on macho? I'm not sure if I'm understanding this correctly because it doesn't seem like that could pass testing.

Also, is "weak_def_can_be_hidden" incorrect because __llvm_profile_raw_version isn't supposed to be "hidden"? I'd appreciate it if you could point me to any resources that discuss the difference between weak_def_can_be_hidden and weak_definition -- if there aren't any I can dig a bit more :).


http://reviews.llvm.org/D20078





More information about the llvm-commits mailing list