[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

[Matthias Braun via llvm-commits]

MatzeB added a comment.

You should avoid unnecessary heap allocation of the analysis (see below).
As for the testcase I believe what Quentin was asking was not to create a new .cc file as a test but rather to simplify and cleanup the hoist-spill-lpad.ll according to his suggestions.


================
Comment at: lib/CodeGen/InlineSpiller.cpp:72
@@ -70,1 +71,3 @@
 
+  // Analysis to determine the latest point in a Block to insert spill.
+  std::unique_ptr<InsertPointAnalysis> IPA;
----------------
MatzeB wrote:
> This should better be a member instead of being allocated on the heap. You can add a reset() method to InsertPointAnalysis to enable this.
This comment doesn't contain any additional information over what the user would found in the description of the InsertPointAnalysis class. I'd leave it out.

================
Comment at: lib/CodeGen/InlineSpiller.cpp:72-73
@@ -70,1 +71,4 @@
 
+  // Analysis to determine the latest point in a Block to insert spill.
+  std::unique_ptr<InsertPointAnalysis> IPA;
+
----------------
This should better be a member instead of being allocated on the heap. You can add a reset() method to InsertPointAnalysis to enable this.


Repository:
  rL LLVM

http://reviews.llvm.org/D19884