[PATCH] D20024: [ELF] - Protect first entries of got.plt with RelRo.

[Rafael Espíndola via llvm-commits]

On 6 May 2016 at 20:39, Michael Spencer via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> On Fri, May 6, 2016 at 2:20 PM, Joerg Sonnenberger via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> On Fri, May 06, 2016 at 03:36:10PM -0400, Rafael Espíndola via llvm-commits wrote:
>>> On 6 May 2016 at 14:27, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>> > On 6 May 2016 at 14:23, Rui Ueyama <ruiu at google.com> wrote:
>>> >> Can we simply drop it? I'm wondering if other libc's or dynamic linkers use
>>> >> it.
>>> >
>>> > From what is written in the abi it looks like it would only be used by
>>> > self relocating programs (i.e.: ld.so).
>>> >
>>> > But those could do just what musl does.
>>> >
>>> > Let me give it a try.
>>>
>>> http://reviews.llvm.org/D20028
>>
>> Let's not produce nightmares for poor porters that have to hunt for the
>> obscure bugs it can create please.
>
> I would like to reiterate this. We need to fully understand the
> implications of changes like this, not just look at a few examples and
> decide to ditch it.

In the current lld, the rule is the other way around. We need to fully
understand why it is needed before it is added. This one slipped code
review, but that doesn't make policy.

Cheers,
Rafael