[llvm] r268915 - [X86][SSE] Added TODO comment to add support for AVX512 mask registers to shuffle comments

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 06:30:16 PDT 2016


Author: rksimon
Date: Mon May  9 08:30:16 2016
New Revision: 268915

URL: http://llvm.org/viewvc/llvm-project?rev=268915&view=rev
Log:
[X86][SSE] Added TODO comment to add support for AVX512 mask registers to shuffle comments

This came up in discussion on D19198

Modified:
    llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp
    llvm/trunk/lib/Target/X86/X86MCInstLower.cpp

Modified: llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp?rev=268915&r1=268914&r2=268915&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp (original)
+++ llvm/trunk/lib/Target/X86/InstPrinter/X86InstComments.cpp Mon May  9 08:30:16 2016
@@ -741,6 +741,7 @@ bool llvm::EmitAnyX86InstComments(const
   if (ShuffleMask.empty())
     return false;
 
+  // TODO: Add support for specifying an AVX512 style mask register in the comment.
   if (!DestName) DestName = Src1Name;
   OS << (DestName ? DestName : "mem") << " = ";
 

Modified: llvm/trunk/lib/Target/X86/X86MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86MCInstLower.cpp?rev=268915&r1=268914&r2=268915&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86MCInstLower.cpp Mon May  9 08:30:16 2016
@@ -1109,6 +1109,7 @@ static std::string getShuffleComment(con
     return X86ATTInstPrinter::getRegisterName(RegNum);
   };
 
+  // TODO: Add support for specifying an AVX512 style mask register in the comment.
   StringRef DstName = DstOp.isReg() ? GetRegisterName(DstOp.getReg()) : "mem";
   StringRef Src1Name =
       SrcOp1.isReg() ? GetRegisterName(SrcOp1.getReg()) : "mem";




More information about the llvm-commits mailing list