[llvm] r268902 - Revert "[Mips] Fix use after free."

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Mon May 9 03:31:18 PDT 2016


Author: d0k
Date: Mon May  9 05:31:17 2016
New Revision: 268902

URL: http://llvm.org/viewvc/llvm-project?rev=268902&view=rev
Log:
Revert "[Mips] Fix use after free."

Fixes use after free but breaks tests.

This reverts commit r268901.

Modified:
    llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Modified: llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp?rev=268902&r1=268901&r2=268902&view=diff
==============================================================================
--- llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/Mips/AsmParser/MipsAsmParser.cpp Mon May  9 05:31:17 2016
@@ -4693,7 +4693,8 @@ MipsAsmParser::parseRegisterPair(Operand
   SMLoc E = Parser.getTok().getLoc();
   MipsOperand &Op = static_cast<MipsOperand &>(*Operands.back());
 
-  Operands.back() = MipsOperand::CreateRegPair(Op, S, E, *this);
+  Operands.pop_back();
+  Operands.push_back(MipsOperand::CreateRegPair(Op, S, E, *this));
   return MatchOperand_Success;
 }
 




More information about the llvm-commits mailing list