[PATCH] D19904: XRay: Add entry and exit sleds

Dean Michael Berris via llvm-commits llvm-commits at lists.llvm.org
Sun May 8 23:06:12 PDT 2016


dberris marked an inline comment as done.

================
Comment at: lib/CodeGen/XRayInstrumentation.cpp:72-74
@@ -72,6 +71,5 @@
+    for (auto &T : MBB.terminators()) {
       // FIXME: Handle tail calls here too?
-      if (Terminator.isReturn() && (Terminator.getOpcode() != ISD::CATCHRET ||
-                                    Terminator.getOpcode() != ISD::CLEANUPRET ||
-                                    Terminator.getOpcode() != ISD::EH_RETURN)) {
+      if (T.isReturn() && TII->isNormalReturn(&T)) {
         // Replace return instructions with:
         //   PATCHABLE_RET <Opcode>, <Operand>...
----------------
Thanks!

I've updated the patch to do this. PTAL?


http://reviews.llvm.org/D19904





More information about the llvm-commits mailing list