[PATCH] D19988: Separate the Verifier into an analysis and a transformation pass optionally stripping malformed debug info.

[Mehdi AMINI via llvm-commits]

joker.eph accepted this revision.
This revision is now accepted and ready to land.

================
Comment at: include/llvm/IR/Verifier.h:57
@@ +56,3 @@
+
+class VerifierAnalysis : public AnalysisInfoMixin<VerifierAnalysis> {
+  friend AnalysisInfoMixin<VerifierAnalysis>;
----------------
Doxygen?

================
Comment at: lib/IR/DiagnosticInfo.cpp:127
@@ +126,3 @@
+    DiagnosticPrinter &DP) const {
+  DP << "ignoring invalid debug info in " << getModule();
+}
----------------
I'm worried what this displays, should it be `getModule().getModuleIdentifier()` or something similar?

================
Comment at: lib/IR/Verifier.cpp:4511
@@ -4489,1 +4510,3 @@
+      report_fatal_error("Failed to strip malformed debug info");
+  }
   return PreservedAnalyses::all();
----------------
So from now on the verifier will never assert on invalid debug info but will drop them right?


http://reviews.llvm.org/D19988