[PATCH] D20024: [ELF] - Protect first entries of got.plt with RelRo.

[Rui Ueyama via llvm-commits]

On Fri, May 6, 2016 at 5:39 PM, Michael Spencer via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> On Fri, May 6, 2016 at 2:20 PM, Joerg Sonnenberger via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > On Fri, May 06, 2016 at 03:36:10PM -0400, Rafael Espíndola via
> llvm-commits wrote:
> >> On 6 May 2016 at 14:27, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> >> > On 6 May 2016 at 14:23, Rui Ueyama <ruiu at google.com> wrote:
> >> >> Can we simply drop it? I'm wondering if other libc's or dynamic
> linkers use
> >> >> it.
> >> >
> >> > From what is written in the abi it looks like it would only be used by
> >> > self relocating programs (i.e.: ld.so).
> >> >
> >> > But those could do just what musl does.
> >> >
> >> > Let me give it a try.
> >>
> >> http://reviews.llvm.org/D20028
> >
> > Let's not produce nightmares for poor porters that have to hunt for the
> > obscure bugs it can create please.
>
> I would like to reiterate this. We need to fully understand the
> implications of changes like this, not just look at a few examples and
> decide to ditch it.
>

Yes, it is important to understand what we are doing. At the same time, it
is important to not blindly replicate behaviors of the other linkers.
Creating a general-purpose Unix linker from scratch gives us a historic
chance to flush out bureaucrats and out-of-date behaviors that have been
done over decades. I'd like to carefully examine one by one.


> - Michael Spencer
>
> >
> >> As for the rest of this patch: I think I agree with Rui. The added
> >> value is really small. If going for safety you should really disable
> >> lazy loading or even just compile with -fno-plt.
> >
> > I agree on this part though, it seems pointless complexity for an edge
> > case, that doesn't give much.
> >
> > Joerg
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160506/268ee651/attachment.html>