[PATCH] D19987: Allow the LTO code generator to drop malformed debug info from the input

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: include/llvm/IR/Verifier.h:57
@@ +56,3 @@
+/// "recovered" from by stripping the debug info.
+bool verifyModule(bool &BrokenDebugInfo, const Module &M, raw_ostream *OS);
+
----------------
Not defined anywhere?

================
Comment at: include/llvm/IR/Verifier.h:77
@@ +76,3 @@
+/// "recovered" from by stripping the debug info.
+bool verifyModule(bool &BrokenDebugInfo, const Module &M, raw_ostream *OS);
+
----------------
Not defined anywhere?

================
Comment at: lib/IR/Verifier.cpp:4506
@@ +4505,3 @@
+  // Strip broken debug info.
+  if (Res.DebugInfoBroken && StripDebugInfo(M)) {
+    DiagnosticInfoIgnoringInvalidDebugMetadata DiagInvalid(M);
----------------
I'd be worried if `Res.DebugInfoBroken && !StripDebugInfo(M)` ; it seems to be the cause for an internal error.


http://reviews.llvm.org/D19987