[PATCH] D20024: [ELF] - Protect first entries of got.plt with RelRo.

[Joerg Sonnenberger via llvm-commits]

On Fri, May 06, 2016 at 03:36:10PM -0400, Rafael Espíndola via llvm-commits wrote:
> On 6 May 2016 at 14:27, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> > On 6 May 2016 at 14:23, Rui Ueyama <ruiu at google.com> wrote:
> >> Can we simply drop it? I'm wondering if other libc's or dynamic linkers use
> >> it.
> >
> > From what is written in the abi it looks like it would only be used by
> > self relocating programs (i.e.: ld.so).
> >
> > But those could do just what musl does.
> >
> > Let me give it a try.
> 
> http://reviews.llvm.org/D20028

Let's not produce nightmares for poor porters that have to hunt for the
obscure bugs it can create please.

> As for the rest of this patch: I think I agree with Rui. The added
> value is really small. If going for safety you should really disable
> lazy loading or even just compile with -fno-plt.

I agree on this part though, it seems pointless complexity for an edge
case, that doesn't give much.

Joerg