[compiler-rt] r268608 - IR value profile testing cleanup

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 12:40:12 PDT 2016


On Fri, May 6, 2016 at 12:22 PM, Pete Cooper <peter_cooper at apple.com> wrote:

> Hi David
>
> This is also failing on some of our internal bots.  Would it be possible
> to revert (or disable this for Darwin if its the only affected platform)
> while we work out the issue?
>
> Thanks,
> Pete
>
> On May 5, 2016, at 2:02 PM, Pete Cooper <peter_cooper at apple.com> wrote:
>
>
> On May 5, 2016, at 11:53 AM, Xinliang David Li <davidxl at google.com> wrote:
>
> Can you send me two files in : %t.ir.profdata and %t.ir.proftxt?
>
> Sure.  Here they are for x86_64.  Sorry, had to wait for a build to
> regenerate them
>
> <instrprof-value-prof.test.tmp.ir.proftxt>
> <instrprof-value-prof.test.tmp.profdata>
>
>
can you send me  instrprof-value-prof.test.tmp.ir.profdata file (notice the
.ir. in the file name)?

thanks,

David


> BTW, assuming a build hasn’t cleaned them out, I was able to get these
> from the Jenkins workspace view.  That is, this view:
> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/ws/clang-build/projects/compiler-rt/test/profile/Profile-x86_64/Output/
>
> Thanks,
> Pete
>
>
> RUN: llvm-profdata merge -text  %t.ir.profdata -o %t.ir.proftxt
>
> thanks,
>
> David
>
>
>
>
> On Thu, May 5, 2016 at 11:46 AM, Pete Cooper <peter_cooper at apple.com>
> wrote:
>
>> Hi David
>>
>> I’m seeing a failure on the bots which appears to be from this commit.
>> Would you mind taking a look?
>>
>> Also CCing Quentin as this is only failure on the GlobalISel bot which is
>> weird as i can’t think of a reason for a difference in behaviour from the
>> regular bots.
>>
>> The log is here:
>> http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-globalisel_check/1544/console
>>
>> And the error is:
>>
>> Exit Code: 1
>>
>> Command Output (stderr):
>> --
>>
>> /Users/buildslave/jenkins/sharedspace/clang-stage1-cmake-RA_workspace/llvm/projects/compiler-rt/test/profile/Inputs/instrprof-value-prof-real.c:46:8:
>> error: expected string not found in input
>>
>> // IR: :ir
>>        ^
>> <stdin>:1:1: note: scanning from here
>> foo_1_1_1_1_2_2_2_1_1
>> ^
>> <stdin>:2:12: note: possible intended match here
>> # Func Hash:
>>
>>
>> Thanks,
>> Pete
>>
>> On May 4, 2016, at 10:41 PM, Xinliang David Li via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>> Author: davidxl
>> Date: Thu May  5 00:41:02 2016
>> New Revision: 268608
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=268608&view=rev
>> Log:
>> IR value profile testing cleanup
>>
>> Modified:
>>    compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c
>>    compiler-rt/trunk/test/profile/instrprof-value-prof.test
>>
>> Modified:
>> compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c?rev=268608&r1=268607&r2=268608&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c
>> (original)
>> +++ compiler-rt/trunk/test/profile/Inputs/instrprof-value-prof-real.c Thu
>> May  5 00:41:02 2016
>> @@ -43,7 +43,7 @@ int main() {
>>
>>   return 0;
>> }
>> -
>> +// IR: :ir
>> // CHECK-LABEL:  main:
>> // CHECK: [ 0, foo_1_1_1_1_1_1_1_1_1, 1000 ]
>> // CHECK-NEXT: [ 0, foo_1_1_1_1_1_1_1_1_2, 999 ]
>>
>> Modified: compiler-rt/trunk/test/profile/instrprof-value-prof.test
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/profile/instrprof-value-prof.test?rev=268608&r1=268607&r2=268608&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/test/profile/instrprof-value-prof.test (original)
>> +++ compiler-rt/trunk/test/profile/instrprof-value-prof.test Thu May  5
>> 00:41:02 2016
>> @@ -3,9 +3,10 @@
>> // RUN: llvm-profdata merge -o %t.profdata %t.profraw
>> // RUN: llvm-profdata show --all-functions -ic-targets  %t.profdata |
>> FileCheck  %S/Inputs/instrprof-value-prof-real.c
>>
>> -// do two step build before the clang option is ready
>> -// RUN: %clang -O2 -mllvm -disable-vp=false -Xclang
>> -fprofile-instrument=llvm -c -o %t.ir.o
>>  %S/Inputs/instrprof-value-prof-real.c
>> -// RUN: %clang_profgen -O2 -o %t.ir  %t.ir.o
>> +// IR level instrumentation
>> +// RUN: %clang_profgen -O2 -mllvm -disable-vp=false -Xclang
>> -fprofile-instrument=llvm -o %t.ir  %S/Inputs/instrprof-value-prof-real.c
>> // RUN: env LLVM_PROFILE_FILE=%t.ir.profraw %run %t.ir
>> // RUN: llvm-profdata merge -o %t.ir.profdata %t.ir.profraw
>> // RUN: llvm-profdata show --all-functions -ic-targets  %t.ir.profdata |
>> FileCheck  %S/Inputs/instrprof-value-prof-real.c
>> +// RUN: llvm-profdata merge -text  %t.ir.profdata -o %t.ir.proftxt
>> +// RUN: FileCheck  %S/Inputs/instrprof-value-prof-real.c
>> --check-prefix=IR < %t.ir.proftxt
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160506/c3b65911/attachment.html>


More information about the llvm-commits mailing list