[PATCH] CMake: generate check targets for lit suites without their own lit.cfgs

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 12:11:55 PDT 2016


My only concern about this approach is performance of the glob evaluation. As long as it isn’t too slow this LGTM.

-Chris

> On May 5, 2016, at 2:19 PM, Justin Bogner <mail at justinbogner.com> wrote:
> 
> Justin Bogner <mail at justinbogner.com> writes:
>> Currently our cmake generates targets like check-llvm-unit and
>> check-llvm-transforms-loopunroll-x86, but not check-llvm-transforms or
>> check-llvm-transforms-adce. This is because the search for test suites
>> only lists the ones with a custom lit.cfg or lit.local.cfg.
>> 
>> The attached patch does something a little smarter - any directory under
>> test that isn't called Inputs or inside a directory called Inputs is a
>> test suite. I suspect we can't actually do it this way though, since I
>> guess windows probably doesn't have find. Thoughts?
> 
> I guess that version was too hokey to merit a response. Here's one that
> only uses cmake machinery that shouldn't be contentious at all. WDYT?
> 
> <lit-suites-cmake-only.patch>



More information about the llvm-commits mailing list