[PATCH] D20022: Make llvm-pdbdump print CodeView type records

[Zachary Turner via llvm-commits]

zturner added inline comments.

================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:365-366
@@ +364,4 @@
+
+      if (opts::DumpTpiRecordBytes)
+        P.printBinaryBlock("Bytes", Type.LeafData);
+    }
----------------
rnk wrote:
> Any reason not to pass this boolean in above as the `PrintRecordBytes` to the dumper constructor instead of printing the bytes manually here? If you prefer "Bytes" to "LeafData" we can totally change it.
Because both the type record and the binary data are conditional based on different conditions.  In other words, if someone passed `-dump-tpi-record-bytes` but not `-dump-tpi-records` then they would want to see the block data but not the record data, and there's no way to do that.  I could change the interface to the type dumper, but this seemed simpler.


http://reviews.llvm.org/D20022