[PATCH] D19873: [mips][micromips] Make getPointerRegClass() result depend on the instruction.

Simon Dardis via llvm-commits llvm-commits at lists.llvm.org
Fri May 6 07:02:03 PDT 2016


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

Unless I'm mistaken in my reading of the instruction definition, lwgp takes a signed offset.

LGTM with that changed.


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:1086
@@ +1085,3 @@
+  template <unsigned Bits> bool isMemWithUimmWordAlignedOffsetGP() const {
+    return isMem() && isConstantMemOff() && isUInt<Bits>(getConstantMemOff())
+      && (getConstantMemOff() % 4 == 0) && getMemBase()->isRegIdx()
----------------
isInt instead of isUInt. LWGP takes a signed offset, not an unsigned one.


http://reviews.llvm.org/D19873





More information about the llvm-commits mailing list