[PATCH] D20008: ThinLTO: fix assertion and refactor check for hidden use from inline ASM in a helper function

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a test added and nit fixed.


================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:230
@@ -229,3 @@
-    // generation.
-    assert((!V->hasLocalLinkage() || !isPerformingImport()) &&
-           "Should have blocked importing from module with local used");
----------------
Oh I see, hitting this assert I guess.

================
Comment at: lib/Transforms/Utils/FunctionImportUtils.cpp:244
@@ -260,1 +243,2 @@
 }
+
----------------
Extraneous new line added.


http://reviews.llvm.org/D20008