[PATCH] D19503: [MemorySSA] Overhaul CachingMemorySSAWalker's cache to allow more selective cache invalidation

[Philip Reames via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Just to make sure I'm understand the context correctly, we're removing a memorydef which has been determined to be dead (i.e. dse) and as a result, leaving the memory phi in place pointing at the definition before the one we removed is correct but not necessarily optimally precise?  That seems reasonable.  Possibly part of the API should be the precision required?

Also, the presence of both code motion and semantic changes makes this essentially impossible to review quickly.  Please make the code motion changes separately, land them, and then update the patch.  If we disagree about where the code lives, we can move it again later.  Your suggestion seems reasonable enough and I doubt we'll care too much.  :)


http://reviews.llvm.org/D19503