[llvm] r268683 - [codeview] Improve some comments

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 13:58:47 PDT 2016


Author: rnk
Date: Thu May  5 15:58:46 2016
New Revision: 268683

URL: http://llvm.org/viewvc/llvm-project?rev=268683&view=rev
Log:
[codeview] Improve some comments

This FIXME was already fixed, and these LF_* enum names were
inconsistent.

Modified:
    llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecord.h
    llvm/trunk/lib/DebugInfo/CodeView/TypeDumper.cpp

Modified: llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecord.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecord.h?rev=268683&r1=268682&r2=268683&view=diff
==============================================================================
--- llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecord.h (original)
+++ llvm/trunk/include/llvm/DebugInfo/CodeView/TypeRecord.h Thu May  5 15:58:46 2016
@@ -299,7 +299,7 @@ struct FuncId {
   // Name: The null-terminated name follows.
 };
 
-// LF_CLASS, LF_STRUCT, LF_INTERFACE
+// LF_CLASS, LF_STRUCTURE, LF_INTERFACE
 struct ClassType {
   ulittle16_t MemberCount; // Number of members in FieldList.
   ulittle16_t Properties;  // ClassOptions bitset
@@ -501,6 +501,7 @@ struct OneMethod {
   bool isIntroducedVirtual() const { return Attrs.isIntroducedVirtual(); }
 };
 
+// LF_METHODLIST
 struct MethodListEntry {
   MemberAttributes Attrs;
   ulittle16_t Padding;
@@ -559,7 +560,7 @@ struct BaseClass {
   // BaseOffset: LF_NUMERIC encoded byte offset of base from derived.
 };
 
-// LF_VBCLASS | LV_IVBCLASS
+// LF_VBCLASS, LF_IVBCLASS
 struct VirtualBaseClass {
   MemberAttributes Attrs; // Access control attributes, etc.
   TypeIndex BaseType;     // Base class type

Modified: llvm/trunk/lib/DebugInfo/CodeView/TypeDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/CodeView/TypeDumper.cpp?rev=268683&r1=268682&r2=268683&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/CodeView/TypeDumper.cpp (original)
+++ llvm/trunk/lib/DebugInfo/CodeView/TypeDumper.cpp Thu May  5 15:58:46 2016
@@ -200,7 +200,6 @@ public:
       : CVTD(CVTD), W(W), PrintRecordBytes(PrintRecordBytes) {}
 
   /// CVTypeVisitor overrides.
-  /// FIXME: Bury these in the .cc file to hide implementation details.
 #define TYPE_RECORD(ClassName, LeafEnum)                                       \
   void visit##ClassName(TypeLeafKind LeafType, const ClassName *Record,        \
                         ArrayRef<uint8_t> LeafData);




More information about the llvm-commits mailing list