[PATCH] D18619: [AArch64] Combine callee-save and local stack SP adjustment instructions.
Tim Northover via llvm-commits
llvm-commits at lists.llvm.org
Thu May 5 13:44:46 PDT 2016
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Hi Geoff,
I think this looks basically good now (just trivia left), thanks for all the updates and feel free to commit without uploading another version here.
Tim.
================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:402
@@ +401,3 @@
+ default:
+ assert(!"Unexpected callee-save save/restore opcode!");
+ break;
----------------
llvm_unreachable is probably better here. Though I'd probably write the whole thing as an assertion (it's using up a lot of vertical space for something quite trivial).
http://reviews.llvm.org/D18619
More information about the llvm-commits
mailing list