[PATCH] D19986: Refactor the Verifier so it can diagnose IR validation errors and debug info metadata errors separately. (NFC)

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/IR/Verifier.cpp:262
@@ -240,3 +261,3 @@
 public:
-  explicit Verifier(raw_ostream *OS)
+  explicit Verifier(raw_ostream *OS, bool treatBrokenDebugInfoAsError = true)
       : VerifierSupport(OS), Context(nullptr), LandingPadResultTy(nullptr),
----------------
joker.eph wrote:
> First letter should be capital.
You can either:

 - name it slightly differently than the member
 - keep the same name if you can use the initializer list (see the other comment below)
 - use this->TreatBrokenDebugInfoAsError = TreatBrokenDebugInfoAsError if you want to keep the same name but can't use the initializer list.

(I don't really mind, but I don't think I've seen the last option frequently used in LLVM)


http://reviews.llvm.org/D19986