[PATCH] D19972: [scan-build] fix warnings emitted on LLVM dsymutil code base

[David Blaikie via llvm-commits]

On Thu, May 5, 2016 at 12:57 PM, Frederic Riss via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> friss added a subscriber: friss.
> friss added a comment.
>
> Attr can never be null here because one of Loc or Block will be non-null.
> This looks like a deficiency of the static analyzer. I'd rather initialize
> Attr in each of the branches of the if above if that helps.
>

I've started a thread on cfe-dev and llvm-dev to discuss this. I'm not sure
we want to litter the codebase with unnecessary initializations and null
checks to satisfy the static analyzer if it's being overly pessimistic.
(but maybe we do - in any case, they seem pervasive and invasive enough
that a general discussion/consensus seems like it'd be useful)


>
>
> http://reviews.llvm.org/D19972
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160505/6f9e6fa2/attachment.html>