[PATCH] D19964: [scan-build] fix warnings emiited on LLVM Analysis code base

silviu.baranga@arm.com via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 12:28:19 PDT 2016


sbaranga added a subscriber: sbaranga.

================
Comment at: lib/Analysis/LoopInfo.cpp:515
@@ -514,1 +514,3 @@
 
+  assert(Unloop && "Unloop cannot be NULL");
+
----------------
Do we really need three of these?

================
Comment at: lib/Analysis/ScalarEvolution.cpp:5557
@@ -5556,1 +5556,3 @@
 
+  assert(ENT && "ExitNotTakenExtras array is NULL, cannot further compute exits");
+
----------------
Maybe a more meaningful string here would be "ExitNotTakenExtras is NULL while having more than one exit".




http://reviews.llvm.org/D19964





More information about the llvm-commits mailing list