[PATCH] D19986: Refactor the Verifier so it can diagnose IR validation errors and debug info metadata errors separately. (NFC)

[Mehdi AMINI via llvm-commits]

joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.

LGTM (see inline nits)


================
Comment at: lib/IR/Verifier.cpp:262
@@ -240,3 +261,3 @@
 public:
-  explicit Verifier(raw_ostream *OS)
+  explicit Verifier(raw_ostream *OS, bool treatBrokenDebugInfoAsError = true)
       : VerifierSupport(OS), Context(nullptr), LandingPadResultTy(nullptr),
----------------
First letter should be capital.

================
Comment at: lib/IR/Verifier.cpp:265
@@ +264,3 @@
+        SawFrameEscape(false) {
+    TreatBrokenDebugInfoAsError = treatBrokenDebugInfoAsError;
+  }
----------------
Any reason not to put it in the initializer list?


http://reviews.llvm.org/D19986