[PATCH] D19921: [esan] EfficiencySanitizer shadow memory

[Derek Bruening via llvm-commits]

bruening added inline comments.

================
Comment at: lib/esan/esan_shadow.h:78
@@ +77,3 @@
+// shadow(shadow) ends up disjoint from shadow(app):
+//
+// [0x00001400'00000000, 0x00001500'00000000)
----------------
filcab wrote:
> `Mapping` is more ambiguous, and it's a top-level (in ESan) name.
> `ShadowMapping` is explicitly for a shadow memory mapping. We only have the one class and is easily reachable everywhere in ESan. It should be more explicit.
I'm seeing requests for s/ShadowMapping/Mapping/ here, but later s/ShadowMapping/Mapping/ for the global variable; similarly, s/ShadowScale/Scale/ for the field, yet later s/Scale/ShadowScale/ for the parameter.  The global variable is the one referenced the most externally and it is ShadowMapping.  "Mapping" is used throughout the sanitizers: asan_mapping.h, AsanMappingProfile[], ASAN_FIXED_MAPPING, tsan's struct Mapping, enum MappingType.


http://reviews.llvm.org/D19921