[PATCH] D19528: [ELF] - Implemented -z combrelocs/nocombreloc.

[George Rimar via llvm-commits]

grimar added a comment.

In http://reviews.llvm.org/D19528#422386, @rafael wrote:

> Please do simplify the patch to first not set any new DT_ and sort only by offset. Lets benchmark just that first.


Ok, will try tomorrow.


================
Comment at: ELF/Writer.cpp:168
@@ -166,3 +167,3 @@
     GotPlt.reset(new GotPltSection<ELFT>);
-    RelaPlt.reset(new RelocationSection<ELFT>(S));
+    RelaPlt.reset(new RelocationSection<ELFT>(S, false /*Sort*/));
   }
----------------
rafael wrote:
> Why can't you sort this? It shouldn't hurt when being lazy and it should help otherwise.
Good point.


http://reviews.llvm.org/D19528