[llvm] r268631 - Remove bit-rotten CppBackend.

Thu May 5 07:48:44 PDT 2016

Awesome.

BTW, now the only thing that inherits from TargetMachine is
LLVMTargetMachine. Should we merge the two?

Cheers,
Rafael

On 5 May 2016 at 10:35, James Y Knight via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: jyknight
> Date: Thu May  5 09:35:40 2016
> New Revision: 268631
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268631&view=rev
> Log:
> Remove bit-rotten CppBackend.
>
> This backend was supposed to generate C++ code which will re-construct
> the LLVM IR passed as input. This seems to me to have very marginal
> usefulness in the first place.
>
> However, the code has never been updated to use IRBuilder, which makes
> its current value negative -- people who look at the output may be
> steered to use the *wrong* C++ APIs to construct IR.
>
> Furthermore, it's generated code that doesn't compile since at least
> 2013.
>
> Differential Revision: http://reviews.llvm.org/D19942
>
> Removed:
>     llvm/trunk/lib/Target/CppBackend/
>     llvm/trunk/test/CodeGen/CPP/
> Modified:
>     llvm/trunk/CMakeLists.txt
>     llvm/trunk/docs/CodeGenerator.rst
>     llvm/trunk/docs/GettingStarted.rst
>     llvm/trunk/lib/Target/LLVMBuild.txt
>     llvm/trunk/utils/GenLibDeps.pl
>
> Modified: llvm/trunk/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=268631&r1=268630&r2=268631&view=diff
> ==============================================================================
> --- llvm/trunk/CMakeLists.txt (original)
> +++ llvm/trunk/CMakeLists.txt Thu May  5 09:35:40 2016
> @@ -226,7 +226,6 @@ set(LLVM_ALL_TARGETS
>    AMDGPU
>    ARM
>    BPF
> -  CppBackend
>    Hexagon
>    Mips
>    MSP430
>
> Modified: llvm/trunk/docs/CodeGenerator.rst
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/CodeGenerator.rst?rev=268631&r1=268630&r2=268631&view=diff
> ==============================================================================
> --- llvm/trunk/docs/CodeGenerator.rst (original)
> +++ llvm/trunk/docs/CodeGenerator.rst Thu May  5 09:35:40 2016
> @@ -1771,13 +1771,11 @@ table that summarizes what features are
>  Target Feature Matrix
>  ---------------------
>
> -Note that this table does not include the C backend or Cpp backends, since they
> -do not use the target independent code generator infrastructure.  It also
> -doesn't list features that are not supported fully by any target yet.  It
> -considers a feature to be supported if at least one subtarget supports it.  A
> -feature being supported means that it is useful and works for most cases, it
> -does not indicate that there are zero known bugs in the implementation.  Here is
> -the key:
> +Note that this table does not list features that are not supported fully by any
> +target yet.  It considers a feature to be supported if at least one subtarget
> +supports it.  A feature being supported means that it is useful and works for
> +most cases, it does not indicate that there are zero known bugs in the
> +implementation.  Here is the key:
>
>  :raw-html:`<table border="1" cellspacing="0">`
>  :raw-html:`<tr>`
>
> Modified: llvm/trunk/docs/GettingStarted.rst
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/GettingStarted.rst?rev=268631&r1=268630&r2=268631&view=diff
> ==============================================================================
> --- llvm/trunk/docs/GettingStarted.rst (original)
> +++ llvm/trunk/docs/GettingStarted.rst Thu May  5 09:35:40 2016
> @@ -730,9 +730,9 @@ used by people developing LLVM.
>  |                         | the configure script. The default list is defined  |
>  |                         | as ``LLVM_ALL_TARGETS``, and can be set to include |
>  |                         | out-of-tree targets. The default value includes:   |
> -|                         | ``AArch64, AMDGPU, ARM, BPF, CppBackend, Hexagon,  |
> -|                         | Mips, MSP430, NVPTX, PowerPC, Sparc, SystemZ       |
> -|                         | X86, XCore``.                                      |
> +|                         | ``AArch64, AMDGPU, ARM, BPF, Hexagon, Mips,        |
> +|                         | MSP430, NVPTX, PowerPC, Sparc, SystemZ, X86,       |
> +|                         | XCore``.                                           |
>  +-------------------------+----------------------------------------------------+
>  | LLVM_ENABLE_DOXYGEN     | Build doxygen-based documentation from the source  |
>  |                         | code This is disabled by default because it is     |
>
> Modified: llvm/trunk/lib/Target/LLVMBuild.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/LLVMBuild.txt?rev=268631&r1=268630&r2=268631&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/LLVMBuild.txt (original)
> +++ llvm/trunk/lib/Target/LLVMBuild.txt Thu May  5 09:35:40 2016
> @@ -24,7 +24,6 @@ subdirectories =
>   AArch64
>   AVR
>   BPF
> - CppBackend
>   Lanai
>   Hexagon
>   MSP430
>
> Modified: llvm/trunk/utils/GenLibDeps.pl
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/GenLibDeps.pl?rev=268631&r1=268630&r2=268631&view=diff
> ==============================================================================
> --- llvm/trunk/utils/GenLibDeps.pl (original)
> +++ llvm/trunk/utils/GenLibDeps.pl Thu May  5 09:35:40 2016
> @@ -96,7 +96,6 @@ if ($PEROBJ) {
>      $libpath =~ s/^AsmPrinter/CodeGen\/AsmPrinter/;
>      $libpath =~ s/^BitReader/Bitcode\/Reader/;
>      $libpath =~ s/^BitWriter/Bitcode\/Writer/;
> -    $libpath =~ s/^CppBackend/Target\/CppBackend/;
>      $libpath =~ s/^MSIL/Target\/MSIL/;
>      $libpath =~ s/^Core/IR/;
>      $libpath =~ s/^Instrumentation/Transforms\/Instrumentation/;
> @@ -137,7 +136,6 @@ if ($PEROBJ) {
>      $libpath =~ s/^AsmPrinter/CodeGen\/AsmPrinter/;
>      $libpath =~ s/^BitReader/Bitcode\/Reader/;
>      $libpath =~ s/^BitWriter/Bitcode\/Writer/;
> -    $libpath =~ s/^CppBackend/Target\/CppBackend/;
>      $libpath =~ s/^MSIL/Target\/MSIL/;
>      $libpath =~ s/^Core/VMCore/;
>      $libpath =~ s/^Instrumentation/Transforms\/Instrumentation/;
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits