[PATCH] D19970: [scan-build] fix warnings emitted on LLVM MachineCode code baseFix logic error warnings of the type "called C++ object pointer isnull" emitted by Clang Static Analyzer on the following file:- lib/MC/MCParser/AsmParser.cpp.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu May 5 07:04:47 PDT 2016


When is Sec null?

On 5 May 2016 at 09:44, Apelete Seketeli <apelete at seketeli.net> wrote:
> apelete created this revision.
> apelete added reviewers: grosbach, rafael.
> apelete added a subscriber: llvm-commits.
>
> Signed-off-by: Apelete Seketeli <apelete at seketeli.net>
>
> http://reviews.llvm.org/D19970
>
> Files:
>   lib/MC/MCParser/AsmParser.cpp
>
> Index: lib/MC/MCParser/AsmParser.cpp
> ===================================================================
> --- lib/MC/MCParser/AsmParser.cpp
> +++ lib/MC/MCParser/AsmParser.cpp
> @@ -657,7 +657,7 @@
>    // section and generate a .file directive.
>    if (getContext().getGenDwarfForAssembly()) {
>      MCSection *Sec = getStreamer().getCurrentSection().first;
> -    if (!Sec->getBeginSymbol()) {
> +    if (Sec && !Sec->getBeginSymbol()) {
>        MCSymbol *SectionStartSym = getContext().createTempSymbol();
>        getStreamer().EmitLabel(SectionStartSym);
>        Sec->setBeginSymbol(SectionStartSym);
>
>


More information about the llvm-commits mailing list