[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

[Eric Christopher via llvm-commits]

echristo added a comment.

One inline comment about the patch and a couple about the testcase. If you could look through the testcase and see if there's anything else that can be removed it'd be appreciated.

-eric


================
Comment at: lib/CodeGen/SplitKit.h:124-127
@@ -123,6 +123,6 @@
 
   /// analyze - set CurLI to the specified interval, and analyze how it may be
   /// split.
   void analyze(const LiveInterval *li);
 
   /// didRepairRange() - Returns true if CurLI was invalid and has been repaired
----------------
wmi wrote:
> echristo wrote:
> > I'm not sure I get it after your changes. Can you explain what you're doing now with setParent in a bit more detail?
> I use setParent to set SplitAnalysis::CurLi, which will be used in SplitAnalysis::computeLastSplitPoint to compute the last split point, i.e., insert point of bb.
Why aren't you just doing something like:

  if (SA->getParent() != OrigLi)
    analyze(OrigLi);
  SA->getLastSplitPointIter(BB);

or some such? I'm probably missing something here :)



================
Comment at: test/CodeGen/X86/hoist-spill-lpad.ll:112
@@ +111,3 @@
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.start(i64, i8* nocapture)
+
----------------
Can delete.

================
Comment at: test/CodeGen/X86/hoist-spill-lpad.ll:123
@@ +122,3 @@
+; Function Attrs: argmemonly nounwind
+declare void @llvm.lifetime.end(i64, i8* nocapture)
+
----------------
Can delete.


http://reviews.llvm.org/D19884