[llvm] r268597 - [ThinLTO] Remove missed piece of lazy summary reading support (NFC)

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 19:30:49 PDT 2016


Author: tejohnson
Date: Wed May  4 21:30:48 2016
New Revision: 268597

URL: http://llvm.org/viewvc/llvm-project?rev=268597&view=rev
Log:
[ThinLTO] Remove missed piece of lazy summary reading support (NFC)

Missed in r267097.

Modified:
    llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp

Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=268597&r1=268596&r2=268597&view=diff
==============================================================================
--- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)
+++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Wed May  4 21:30:48 2016
@@ -526,11 +526,6 @@ public:
   std::error_code parseSummaryIndexInto(std::unique_ptr<DataStreamer> Streamer,
                                         ModuleSummaryIndex *I);
 
-  /// \brief Interface for parsing a summary lazily.
-  std::error_code
-  parseGlobalValueSummary(std::unique_ptr<DataStreamer> Streamer,
-                          ModuleSummaryIndex *I, size_t SummaryOffset);
-
 private:
   std::error_code parseModule();
   std::error_code parseValueSymbolTable(
@@ -6331,49 +6326,6 @@ std::error_code ModuleSummaryIndexBitcod
   }
 }
 
-// Parse the summary information at the given offset in the buffer into
-// the index. Used to support lazy parsing of summaries from the
-// combined index during importing.
-// TODO: This function is not yet complete as it won't have a consumer
-// until ThinLTO function importing is added.
-std::error_code ModuleSummaryIndexBitcodeReader::parseGlobalValueSummary(
-    std::unique_ptr<DataStreamer> Streamer, ModuleSummaryIndex *I,
-    size_t SummaryOffset) {
-  TheIndex = I;
-
-  if (std::error_code EC = initStream(std::move(Streamer)))
-    return EC;
-
-  // Sniff for the signature.
-  if (!hasValidBitcodeHeader(Stream))
-    return error("Invalid bitcode signature");
-
-  Stream.JumpToBit(SummaryOffset);
-
-  BitstreamEntry Entry = Stream.advanceSkippingSubblocks();
-
-  switch (Entry.Kind) {
-  default:
-    return error("Malformed block");
-  case BitstreamEntry::Record:
-    // The expected case.
-    break;
-  }
-
-  // TODO: Read a record. This interface will be completed when ThinLTO
-  // importing is added so that it can be tested.
-  SmallVector<uint64_t, 64> Record;
-  switch (Stream.readRecord(Entry.ID, Record)) {
-  case bitc::FS_COMBINED:
-  case bitc::FS_COMBINED_PROFILE:
-  case bitc::FS_COMBINED_GLOBALVAR_INIT_REFS:
-  default:
-    return error("Invalid record");
-  }
-
-  return std::error_code();
-}
-
 std::error_code ModuleSummaryIndexBitcodeReader::initStream(
     std::unique_ptr<DataStreamer> Streamer) {
   if (Streamer)




More information about the llvm-commits mailing list