[PATCH] D19440: [GVN] Do local FRE for unordered atomic loads

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 17:26:51 PDT 2016


reames added a comment.

Have addressed comments and will land the resulting patch shortly per previous LGTM


================
Comment at: test/Transforms/GVN/atomic.ll:123
@@ +122,3 @@
+; CHECK-LABEL: @test13(
+; atomic to non-atomic forwarding is legal
+define i32 @test13(i1 %B, i32* %P1) {
----------------
jfb wrote:
> So I understand: this isn't a new behavior, right? It's a good test, but your change doesn't make this test pass, it already did before. test13b is the new one :)
Yes.  I didn't actually confirm that it worked previously, I just copied my set of standard tests and started making them work for this pass.  :)


http://reviews.llvm.org/D19440





More information about the llvm-commits mailing list