[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

[Eric Christopher via llvm-commits]

echristo added inline comments.

================
Comment at: lib/CodeGen/InlineSpiller.cpp:1397
@@ +1396,3 @@
+    LiveInterval &OrigLI = LIS.getInterval(OrigReg);
+    // set current interval for SA to compute LastSplitPoint of BB.
+    SA->setParent(&OrigLI);
----------------
Capital 'S' at the beginning of the sentence. 

Perhaps: "Use the current interval for SA to compute a safe insertion point in the target basic block." 

================
Comment at: lib/CodeGen/SplitKit.h:124-127
@@ -123,6 +123,6 @@
 
   /// analyze - set CurLI to the specified interval, and analyze how it may be
   /// split.
   void analyze(const LiveInterval *li);
 
   /// didRepairRange() - Returns true if CurLI was invalid and has been repaired
----------------
I'm not sure I get it after your changes. Can you explain what you're doing now with setParent in a bit more detail?


http://reviews.llvm.org/D19884