[PATCH] D19940: Convert PDB error handling into using std::error_code instead of custom error codes

[David Blaikie via llvm-commits]

On Wed, May 4, 2016 at 3:58 PM, Zachary Turner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> zturner added a comment.
>
> How strong of a recommendation is this?  I don't know much about the
> `Error` class.
>

Just a "this might be of interest/relevance" - we have loads of error_code
code already, and Error isn't really proved out as the One True Way
forward, so I'm happy leaving it to you to decide which seems best. Just
bringing it up so you can look into it if you like, etc.

As Majnemer says, also helps make more descriptive messages
convenient/easy. And it does have mechanisms for interoperating with
error_code when you need/have to because not everything is ported over.

Apple folks are certainly working on plumbing Error through libObject at
least on the MachO side of things.So that'll make some nearby APIs possibly
llvm::Error-y in the short/medium term.

But whatever works best for you.


>
>
> http://reviews.llvm.org/D19940
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160504/552e1646/attachment.html>