[PATCH] D19805: [SelectionDAG] BITREVERSE vector legalization of bit operations

Nadav Rotem via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 15:02:19 PDT 2016


LGTM. 

> On May 2, 2016, at 7:18 AM, Simon Pilgrim via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> RKSimon created this revision.
> RKSimon added a reviewer: jmolloy.
> RKSimon added a subscriber: llvm-commits.
> RKSimon set the repository for this revision to rL LLVM.
> 
> Vector bit operations are typically promoted instead of having custom lowering. This patch changes the isOperationLegalOrCustom tests for vector AND/OR operations to use isOperationLegalOrPromote instead, allowing the SSE implementations to stay on the simd unit.
> 
> I can't find any cases where vector AND/OR operations use custom lowering, but if I have missed something it would be possible to add a TLI::isOperationLegalOrCustomOrPromote function to cover all cases - what do you think?
> 
> Repository:
>  rL LLVM
> 
> http://reviews.llvm.org/D19805
> 
> Files:
>  lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
>  test/CodeGen/X86/vector-bitreverse.ll
> 
> <D19805.55815.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list