[PATCH] D19636: [ThinLTO] Add option to emit imports files for distributed backends
Mehdi AMINI via llvm-commits
llvm-commits at lists.llvm.org
Wed May 4 14:04:39 PDT 2016
joker.eph accepted this revision.
joker.eph added a comment.
This revision is now accepted and ready to land.
LGTM, with two remarks.
================
Comment at: include/llvm/LTO/ThinLTOCodeGenerator.h:198
@@ -197,1 +197,3 @@
/**
+ * Compute and emit the list of imported files for each module.
+ */
----------------
for *each* module? I'd say for `\p ModulePath` instead.
================
Comment at: include/llvm/LTO/ThinLTOCodeGenerator.h:201
@@ +200,3 @@
+ void emitImports(StringRef ModulePath, StringRef OutputName,
+ ModuleSummaryIndex &Index);
+
----------------
Same remark as the previous path: this does not really use anything specific to the ThinLTOCodeGenerator.
http://reviews.llvm.org/D19636
More information about the llvm-commits
mailing list