[PATCH] D19848: DeveloperPolicy: Bugreports should be referenced with an URL
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Wed May 4 12:01:18 PDT 2016
I have no problem with the suggestion for the body, but please leave the
PR# bit in the subject. The PR is the least useful part of any subject
to me and I don't want to devote more space to it.
Philip
On 05/02/2016 06:47 PM, Matthias Braun via llvm-commits wrote:
> MatzeB created this revision.
> MatzeB added a subscriber: llvm-commits.
> MatzeB set the repository for this revision to rL LLVM.
> Herald added a subscriber: mcrosier.
>
> Encourage people to use full URLs when referencing problem reports in commit messages. The URL doesn't add much overhead and allows people to click on it when viewing the messages.
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D19848
>
> Files:
> docs/DeveloperPolicy.rst
>
> Index: docs/DeveloperPolicy.rst
> ===================================================================
> --- docs/DeveloperPolicy.rst
> +++ docs/DeveloperPolicy.rst
> @@ -314,7 +314,9 @@
> code snippets and gory details should be left to bug comments, web
> review or the mailing list.
>
> -* If the patch fixes a bug in bugzilla, please include the PR# in the message.
> +* If the patch fixes a bug in bugzilla, please include a reference to
> + http://llvm.org/PR# in the message. Use a full URL rather than just the
> + PR number.
>
> * `Attribution of Changes`_ should be in a separate line, after the end of
> the body, as simple as "Patch by John Doe.". This is how we officially
> @@ -327,7 +329,7 @@
> * If the commit is a bug fix on top of another recently committed patch, or a
> revert or reapply of a patch, include the svn revision number of the prior
> related commit. This could be as simple as "Revert rNNNN because it caused
> - PR#".
> + http://llvm.org/PR#".
>
> For minor violations of these recommendations, the community normally favors
> reminding the contributor of this policy over reverting. Minor corrections and
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160504/a6dd8004/attachment.html>
More information about the llvm-commits
mailing list