[PATCH] D19901: [ProfileData] (llvm) Use Error in InstrProf and Coverage

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 11:47:39 PDT 2016


vsk marked 2 inline comments as done.

================
Comment at: include/llvm/ProfileData/InstrProf.h:278
@@ -282,4 +277,3 @@
 
-inline std::error_code make_error_code(instrprof_error E) {
-  return std::error_code(static_cast<int>(E), instrprof_category());
-}
+class InstrProfError : public ErrorInfo<InstrProfError> {
+public:
----------------
davidxl wrote:
> Should it be templatized and share the def with CoverageMapError?
Good point, I'll have this in the next revision. @lhames, could something like this be worth pulling into Support/Error.h?


http://reviews.llvm.org/D19901





More information about the llvm-commits mailing list