[PATCH] D18960: [lld] Initial implementation of TLSDESC relocation handling

[Ed Maste via llvm-commits]

emaste added inline comments.

================
Comment at: ELF/InputSection.cpp:161-162
@@ -158,1 +160,4 @@
+  case R_TLSDESC_PAGE:
+    return getAArch64Page(Body.getGotPltTlsDescVA<ELFT>() + A) -
+           getAArch64Page(P);
   case R_PLT:
----------------
This is the MI part; why does it reference AArch64?

================
Comment at: ELF/InputSection.h:58-59
@@ -57,2 +57,4 @@
   R_TLSGD_PC,
+  R_TLSDESC,
+  R_TLSDESC_PAGE,
   R_TLSLD,
----------------
Keep in alpha order

================
Comment at: ELF/OutputSections.cpp:88
@@ -79,1 +87,3 @@
   Buf += Target->GotPltHeaderEntriesNum * sizeof(uintX_t);
+  // Since TLSDESC entries will contains nullptr SymbolBody there is no
+  // need to write them down.
----------------
Comment is unclear to me.


http://reviews.llvm.org/D18960