[lld] r268496 - [mips][ias] Only round section sizes when explicitly requested.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed May 4 06:34:05 PDT 2016


Thanks!

On 4 May 2016 at 09:21, Daniel Sanders via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: dsanders
> Date: Wed May  4 08:21:06 2016
> New Revision: 268496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=268496&view=rev
> Log:
> [mips][ias] Only round section sizes when explicitly requested.
>
> As requested by Rafael Espindola in his post-commit comments on r268036. This
> makes the previous behaviour the default while still allowing verification of
> IAS.
>
>
> Modified:
>     lld/trunk/test/ELF/basic-mips.s
>     lld/trunk/test/ELF/mips-26.s
>     lld/trunk/test/ELF/mips-npic-call-pic.s
>
> Modified: lld/trunk/test/ELF/basic-mips.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/basic-mips.s?rev=268496&r1=268495&r2=268496&view=diff
> ==============================================================================
> --- lld/trunk/test/ELF/basic-mips.s (original)
> +++ lld/trunk/test/ELF/basic-mips.s Wed May  4 08:21:06 2016
> @@ -95,7 +95,7 @@ __start:
>  # CHECK-NEXT:     ]
>  # CHECK-NEXT:     Address: 0x20000
>  # CHECK-NEXT:     Offset: 0x10000
> -# CHECK-NEXT:     Size: 16
> +# CHECK-NEXT:     Size: 12
>  # CHECK-NEXT:     Link: 0
>  # CHECK-NEXT:     Info: 0
>  # CHECK-NEXT:     AddressAlignment: 16
> @@ -254,8 +254,8 @@ __start:
>  # CHECK-NEXT:     Offset: 0x10000
>  # CHECK-NEXT:     VirtualAddress: 0x20000
>  # CHECK-NEXT:     PhysicalAddress: 0x20000
> -# CHECK-NEXT:     FileSize: 16
> -# CHECK-NEXT:     MemSize: 16
> +# CHECK-NEXT:     FileSize: 12
> +# CHECK-NEXT:     MemSize: 12
>  # CHECK-NEXT:     Flags [ (0x5)
>  # CHECK-NEXT:       PF_R (0x4)
>  # CHECK-NEXT:       PF_X (0x1)
>
> Modified: lld/trunk/test/ELF/mips-26.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/mips-26.s?rev=268496&r1=268495&r2=268496&view=diff
> ==============================================================================
> --- lld/trunk/test/ELF/mips-26.s (original)
> +++ lld/trunk/test/ELF/mips-26.s Wed May  4 08:21:06 2016
> @@ -25,7 +25,6 @@
>  #
>  # CHECK:      loc:
>  # CHECK-NEXT:   20018:       00 00 00 00     nop
> -# CHECK-NEXT:   2001c:       00 00 00 00     nop
>  # CHECK-NEXT: Disassembly of section .plt:
>  # CHECK-NEXT: .plt:
>  # CHECK-NEXT:   20020:       3c 1c 00 04     lui     $gp, 4
>
> Modified: lld/trunk/test/ELF/mips-npic-call-pic.s
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/mips-npic-call-pic.s?rev=268496&r1=268495&r2=268496&view=diff
> ==============================================================================
> --- lld/trunk/test/ELF/mips-npic-call-pic.s (original)
> +++ lld/trunk/test/ELF/mips-npic-call-pic.s Wed May  4 08:21:06 2016
> @@ -11,16 +11,16 @@
>
>  # CHECK:     Disassembly of section .text:
>  # CHECK-NEXT: __start:
> -# CHECK-NEXT:    20000:       0c 00 80 10     jal     131136 <foo1b+0xC>
> +# CHECK-NEXT:    20000:       0c 00 80 0e     jal     131128 <foo1b+0x4>
>  #                                                            ^-- .pic.foo1a
>  # CHECK-NEXT:    20004:       00 00 00 00     nop
> -# CHECK-NEXT:    20008:       0c 00 80 1c     jal     131184 <foo2+0x10>
> +# CHECK-NEXT:    20008:       0c 00 80 19     jal     131172 <foo2+0x4>
>  #                                                            ^-- .pic.foo2
>  # CHECK-NEXT:    2000c:       00 00 00 00     nop
> -# CHECK-NEXT:    20010:       0c 00 80 14     jal     131152 <foo1b+0x1C>
> +# CHECK-NEXT:    20010:       0c 00 80 12     jal     131144 <foo1b+0x14>
>  #                                                            ^-- .pic.foo1b
>  # CHECK-NEXT:    20014:       00 00 00 00     nop
> -# CHECK-NEXT:    20018:       0c 00 80 1c     jal     131184 <foo2+0x10>
> +# CHECK-NEXT:    20018:       0c 00 80 19     jal     131172 <foo2+0x4>
>  #                                                            ^-- .pic.foo2
>  # CHECK-NEXT:    2001c:       00 00 00 00     nop
>  # CHECK-NEXT:    20020:       0c 00 80 28     jal     131232 <fnpic+0x10>
> @@ -34,29 +34,28 @@
>  #
>  # CHECK:      foo1b:
>  # CHECK-NEXT:    20034:       00 00 00 00     nop
> -# CHECK-NEXT:    20038:       00 00 00 00     nop
> -# CHECK-NEXT:    2003c:       00 00 00 00     nop
>  #
> -# CHECK-NEXT:    20040:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    20044:       08 00 80 0c     j       131120 <foo1a>
> -# CHECK-NEXT:    20048:       27 39 00 30     addiu   $25, $25, 48
> -# CHECK-NEXT:    2004c:       00 00 00 00     nop
> -# CHECK-NEXT:    20050:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    20054:       08 00 80 0d     j       131124 <foo1b>
> -# CHECK-NEXT:    20058:       27 39 00 34     addiu   $25, $25, 52
> +# CHECK-NEXT:    20038:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    2003c:       08 00 80 0c     j       131120 <foo1a>
> +# CHECK-NEXT:    20040:       27 39 00 30     addiu   $25, $25, 48
> +# CHECK-NEXT:    20044:       00 00 00 00     nop
> +# CHECK-NEXT:    20048:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    2004c:       08 00 80 0d     j       131124 <foo1b>
> +# CHECK-NEXT:    20050:       27 39 00 34     addiu   $25, $25, 52
> +# CHECK-NEXT:    20054:       00 00 00 00     nop
> +# CHECK-NEXT:    20058:       00 00 00 00     nop
>  # CHECK-NEXT:    2005c:       00 00 00 00     nop
>  #
>  # CHECK:      foo2:
>  # CHECK-NEXT:    20060:       00 00 00 00     nop
> -# CHECK-NEXT:    20064:       00 00 00 00     nop
> -# CHECK-NEXT:    20068:       00 00 00 00     nop
> -# CHECK-NEXT:    2006c:       00 00 00 00     nop
> -#
> -# CHECK-NEXT:    20070:       3c 19 00 02     lui     $25, 2
> -# CHECK-NEXT:    20074:       08 00 80 18     j       131168 <foo2>
> -# CHECK-NEXT:    20078:       27 39 00 60     addiu   $25, $25, 96
> +#
> +# CHECK-NEXT:    20064:       3c 19 00 02     lui     $25, 2
> +# CHECK-NEXT:    20068:       08 00 80 18     j       131168 <foo2>
> +# CHECK-NEXT:    2006c:       27 39 00 60     addiu   $25, $25, 96
> +# CHECK-NEXT:    20070:       00 00 00 00     nop
> +# CHECK-NEXT:    20074:       00 00 00 00     nop
> +# CHECK-NEXT:    20078:       00 00 00 00     nop
>  # CHECK-NEXT:    2007c:       00 00 00 00     nop
> -
>  #
>  # CHECK:      fpic:
>  # CHECK-NEXT:    20080:       00 00 00 00     nop
> @@ -72,7 +71,6 @@
>  # CHECK-NEXT:    200a0:       3c 19 00 02     lui     $25, 2
>  # CHECK-NEXT:    200a4:       08 00 80 20     j       131200 <fpic>
>  # CHECK-NEXT:    200a8:       27 39 00 80     addiu   $25, $25, 128
> -# CHECK-NEXT:    200ac:       00 00 00 00     nop
>
>    .text
>    .globl __start
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list