[PATCH] D19884: Fix a bug when hoist spill to a BB with landingpad successor

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 23:06:47 PDT 2016


majnemer added a subscriber: majnemer.

================
Comment at: lib/CodeGen/SplitKit.h:124-126
@@ -123,5 +123,5 @@
 
   /// analyze - set CurLI to the specified interval, and analyze how it may be
-  /// split.
-  void analyze(const LiveInterval *li);
+  /// split. If SkipAnalyze is true, skip the analyzeUses call.
+  void analyze(const LiveInterval *li, bool SkipAnalyze = false);
 
----------------
It is a little confusing to have a function called `analyze` which takes a parameter named `SkipAnalyze`.  Perhaps it would be more obvious what you are trying to achieve if the functionality that you desired from `analyze` was split out into another method.


Repository:
  rL LLVM

http://reviews.llvm.org/D19884





More information about the llvm-commits mailing list