Re: [PATCH] D17268: [LAA] Function 'isStridedPtr' returns additional result “Loop *Lp” via function argument and add appropriate checks out of the 'isStridedPtr'.

Tue May 3 15:00:33 PDT 2016

anemet requested changes to this revision.
anemet added a comment.
This revision now requires changes to proceed.

Sorry for not commenting on this earlier but I didn't find the time.

I am not sure what the patch does anymore.  Looks like there is a single call site were we pass in nullptr for the loop and that is the place where we should already accept loop-invariant pointers after http://reviews.llvm.org/rL264243.

Can you please summarize?

I also think that if you want to rename the function you should probably do that in a separate patch.  BTW, I agree with the renaming.

Thanks,
Adam

http://reviews.llvm.org/D17268