[PATCH] D19887: Move CodeViewTypeStream and iterators to DebugInfo/CodeView

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue May 3 14:43:44 PDT 2016


zturner updated this revision to Diff 56064.
zturner added a comment.

Various changes as suggested by previous reviews.

The `TypeStream` is no longer its own class, you can just create an iterator pair.  The `magic` is not part of a PDB's type stream, and it seems to be specific to parsing a `.debug$T` section of an object file, so that logic is extracted into the dumper while the codeview library assumes that the first byte of the stream is the first byte of the first type record.  Updated `DebugInfoPDB` to use this new iterator logic from `DebugInfoCodeview` rather than hand parsing the codeview type stream.


http://reviews.llvm.org/D19887

Files:
  include/llvm/DebugInfo/CodeView/TypeStream.h
  include/llvm/DebugInfo/PDB/Raw/TpiStream.h
  lib/DebugInfo/PDB/Raw/TpiStream.cpp
  tools/llvm-pdbdump/llvm-pdbdump.cpp
  tools/llvm-readobj/COFFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D19887.56064.patch
Type: text/x-patch
Size: 15015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160503/fb660b31/attachment.bin>


More information about the llvm-commits mailing list